Revert "[SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static" #27514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Feb 10, 2020
This comment has been minimized.
This comment has been minimized.
…is not static" This reverts commit 8ce7962.
HyukjinKwon
force-pushed
the
revert-cache-PR
branch
from
32f8dc8 to
f1d8157
Compare
|
Test build #118125 has finished for PR 27514 at commit
|
Member
Author
|
retest this please |
|
Test build #118133 has finished for PR 27514 at commit
|
Member
Author
|
retest this please |
|
Test build #118161 has finished for PR 27514 at commit
|
|
Test build #118162 has finished for PR 27514 at commit
|
Member
|
Thanks! Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 12, 2020
…is not static" ### What changes were proposed in this pull request? This reverts commit 8ce7962. There's variable name conflicts with 8aebc80#diff-39298b470865a4cbc67398a4ea11e767. This can be cleanly ported back to branch-3.0. ### Why are the changes needed? Performance investigation were not made enough and it's not clear if it really beneficial or now. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins tests. Closes #27514 from HyukjinKwon/revert-cache-PR. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Xiao Li <[email protected]>
Member
Author
|
and merged to branch-3.0. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…is not static" ### What changes were proposed in this pull request? This reverts commit 8ce7962. There's variable name conflicts with apache@8aebc80#diff-39298b470865a4cbc67398a4ea11e767. This can be cleanly ported back to branch-3.0. ### Why are the changes needed? Performance investigation were not made enough and it's not clear if it really beneficial or now. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins tests. Closes apache#27514 from HyukjinKwon/revert-cache-PR. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Xiao Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 8ce7962. There's variable name conflicts with 8aebc80#diff-39298b470865a4cbc67398a4ea11e767.
This can be cleanly ported back to branch-3.0.
Why are the changes needed?
Performance investigation were not made enough and it's not clear if it really beneficial or now.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Jenkins tests.